[llvm] r176066 - [fast-isel] Make sure the FastLowerArguments function checks to make sure the

David Blaikie dblaikie at gmail.com
Mon Feb 25 18:33:17 PST 2013


On Mon, Feb 25, 2013 at 5:05 PM, Chad Rosier <mcrosier at apple.com> wrote:

> Author: mcrosier
> Date: Mon Feb 25 19:05:31 2013
> New Revision: 176066
>
> URL: http://llvm.org/viewvc/llvm-project?rev=176066&view=rev
> Log:
> [fast-isel] Make sure the FastLowerArguments function checks to make sure
> the
> arguments type is a simple type.
> rdar://13290455
>

Test case?


>
> Modified:
>     llvm/trunk/lib/Target/ARM/ARMFastISel.cpp
>     llvm/trunk/lib/Target/X86/X86FastISel.cpp
>
> Modified: llvm/trunk/lib/Target/ARM/ARMFastISel.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMFastISel.cpp?rev=176066&r1=176065&r2=176066&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/ARM/ARMFastISel.cpp (original)
> +++ llvm/trunk/lib/Target/ARM/ARMFastISel.cpp Mon Feb 25 19:05:31 2013
> @@ -2922,6 +2922,7 @@ bool ARMFastISel::FastLowerArguments() {
>        return false;
>
>      EVT ArgVT = TLI.getValueType(ArgTy);
> +    if (!ArgVT.isSimple()) return false;
>      switch (ArgVT.getSimpleVT().SimpleTy) {
>      case MVT::i8:
>      case MVT::i16:
>
> Modified: llvm/trunk/lib/Target/X86/X86FastISel.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FastISel.cpp?rev=176066&r1=176065&r2=176066&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86FastISel.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86FastISel.cpp Mon Feb 25 19:05:31 2013
> @@ -1555,6 +1555,7 @@ bool X86FastISel::FastLowerArguments() {
>        return false;
>
>      EVT ArgVT = TLI.getValueType(ArgTy);
> +    if (!ArgVT.isSimple()) return false;
>      switch (ArgVT.getSimpleVT().SimpleTy) {
>      case MVT::i32:
>      case MVT::i64:
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130225/77d0f90e/attachment.html>


More information about the llvm-commits mailing list