[PATCH] [lld][ELF] Order segments properly

Michael Spencer bigcheesegs at gmail.com
Mon Feb 25 12:10:04 PST 2013


  This needs a test. Also, I'm not sure I understand the purpose of this. For example, The PHDR, DYNAMIC, INTERP, and TLS load commands go directly after their associated LOAD. There's no ordering relationship between them.


================
Comment at: SegmentChunks.h:115-125
@@ -114,1 +114,13 @@
   enum SegmentOrder {
+    NULLT,
+    PHDR,
+    INTERP,
+    LOAD,
+    DYNAMIC,
+    NOTE,
+    TLS,
+    EH_FRAME,
+    GNU_STACK,
+    GNU_RELRO,
+    UNKNOWN
+  };
----------------
These should be prefixed with SO_


http://llvm-reviews.chandlerc.com/D458



More information about the llvm-commits mailing list