[PATCH] Fix for PR15347: PPC64: unreachable reached in PPCELFObjectWriter due to missing modifier mapping

Bill Schmidt wschmidt at linux.vnet.ibm.com
Mon Feb 25 07:48:15 PST 2013


Hi Kai!

Thanks for the bug report!  This is a case I missed when adding the
peephole optimization for medium code model and TLS addressing.  It's
easy to reproduce by running test/CodeGen/PowerPC/tls.ll with -O1.  I'll
add a -O1 variant to that test and verify that your proposed patch fixes
it (certainly looks correct).  I'll have the patch in later today.

Thanks,
Bill

On Mon, 2013-02-25 at 06:45 +0100, Kai wrote:
> Hi!
> 
> While trying to port LDC to Linux/PPC64 I encountered a missing modifier 
> in PPCELFObjectWriter for @tprel at l. The attached patch fixes the problem.
> 
> I still try to produce a test case because
> (a) bugpoint did not deliver a useful result
> (b) without an assembler it is not easy to create the required IR code 
> (-O1/-O2/-O3 is required to trigger the bug.)
> 
> Please note that there is at least one version of the ELF ABI spec which 
> specifies a wrong value for R_PPC64_TPREL16_LO.
> 
> Please review.
> 
> Regards
> Kai
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list