[PATCH] Fix encoding of constant in ARM "adr rN, #Const" instruction

[Renato Golin]

On 21 February 2013 09:20, Keith Walker <keith.walker at arm.com> wrote:

> This patch fixes the encoding of the constant value in ARM "adr rN, #Const"
> instruction which currently asserts on some "Const" values that can be
> validly encoded in the instruction.
>

Hi Keith,

Patch looks good. I'd just initialize the variable to zero so that future
code movements only introduce bugs, not segfaults. ;)

+  int SoImmVal = 0;
   if (offset == INT32_MIN) {
     Val = 0x1000;
-    offset = 0;

Also, maybe add one-line comments on what types of values will match in
each case.

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130221/d071e5c8/attachment.html>