[patch] migrating DragonEgg to DIBuilder

Duncan Sands baldrick at free.fr
Wed Feb 20 12:57:32 PST 2013


Hi David,

>     - some Fortran testcases crash, but it's not your fault: it occurs with
>     pointers to arrays, due to hitting this:
>
>        if (isa<ARRAY_TYPE>(type) && TYPE_STRING_FLAG(type) &&
>            isa<INTEGER_TYPE>(TREE_TYPE(__type))) {
>          DEBUGASSERT(0 && "Don't support pascal strings");
>          return DIType();
>        }
>
>     Then the empty DIType is used by the pointer code to try and form a
>     derived type.  I'm not sure why this (ancient) debug code thinks there
>     is a problem with this kind of array, so I will try to fix it to handle
>     them properly.

I've "fixed" this by removing this code and letting "pascal strings" fall
through to the general array case.  I think this is good enough for the moment.
Your patch still applies, and now the only failure is the objc member problem
I mentioned before.

Ciao, Duncan.



More information about the llvm-commits mailing list