[PATCH] review request [MC ELF] symbol table STO support

Eric Christopher echristo at gmail.com
Tue Feb 19 14:10:32 PST 2013


Jack,

If pre-commit review was needed then this is inappropriate to say (as would
be to commit). Also, it was a 3 day weekend in the US so counting any of
those days isn't very appropriate either. I can't think of a reason to be
in a hurry unless this is blocking other changes which you should instead
mention in the ping for review. If someone hasn't reviewed it then it
usually means they've been busy and the change isn't or doesn't seem
trivial, not that it's ok.

I'll see what I can do to get to this soon though.

-eric


On Tue, Feb 19, 2013 at 10:35 AM, Carter, Jack <jcarter at mips.com> wrote:

>  Ping
>
> It's been a week and this isn't a revolutionary change so I will commit
> and look for post committal comments if I haven't heard anything by this
> afternoon.
>
> Cheers,
>
> Jack
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130219/7ca05786/attachment.html>


More information about the llvm-commits mailing list