[PATCH] Clarify the pass name of X86AsmPrinter

Eli Bendersky eliben at google.com
Tue Feb 19 08:40:10 PST 2013


On Fri, Feb 15, 2013 at 4:54 PM, Jim Grosbach <grosbach at apple.com> wrote:
>
> On Feb 15, 2013, at 4:46 PM, Eli Bendersky <eliben at google.com> wrote:
>
>> On Fri, Feb 15, 2013 at 4:42 PM, Jim Grosbach <grosbach at apple.com> wrote:
>>> Seems reasonable to me.
>>>
>>
>> Thanks Jim. Do you think that changing this output based on the actual
>> streamer would be interesting or would it be overdoing it? To be
>> explicit, I'm referring to printing which kind of output is actually
>> being emitted by examining the streamer attached to the AsmPrinter.
>
> I think that's a bit overdoing it, honestly. This output is mainly just for debug output to be able to tell which passes are running in which order. It's probably better that it be static so it's easier to recognize rather than strictly speaking more accurate dynamically.
>

Makes sense, thanks. Applied in 175525. I'll fix it for ARM as well,
and other target maintainer can fix theirs if it itches.

Eli




More information about the llvm-commits mailing list