[llvm] r175124 - Revert "s/grep/FileCheck/ in some tests"

Andrew Trick atrick at apple.com
Wed Feb 13 19:00:57 PST 2013


Author: atrick
Date: Wed Feb 13 21:00:57 2013
New Revision: 175124

URL: http://llvm.org/viewvc/llvm-project?rev=175124&view=rev
Log:
Revert "s/grep/FileCheck/ in some tests"

This reverts commit 8b75e6bc35fb3f9c1e788dbd05084c0f4a60a0f3.

The FileCheck tests are not equivalent:

test/CodeGen/X86/tailcall-structret.ll:6:10: error: expected string not found in input
; CHECK: jmp init
         ^
<stdin>:1:2: note: scanning from here
 .section __TEXT,__text,regular,pure_instructions
 ^
<stdin>:13:2: note: possible intended match here
 jmp _init ## TAILCALL
 ^

Modified:
    llvm/trunk/test/CodeGen/X86/tailcall-structret.ll
    llvm/trunk/test/CodeGen/X86/tailcallbyval.ll
    llvm/trunk/test/CodeGen/X86/tailcallfp.ll
    llvm/trunk/test/CodeGen/X86/tailcallpic1.ll
    llvm/trunk/test/CodeGen/X86/tailcallpic2.ll

Modified: llvm/trunk/test/CodeGen/X86/tailcall-structret.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/tailcall-structret.ll?rev=175124&r1=175123&r2=175124&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/tailcall-structret.ll (original)
+++ llvm/trunk/test/CodeGen/X86/tailcall-structret.ll Wed Feb 13 21:00:57 2013
@@ -1,7 +1,6 @@
-; RUN: llc < %s -march=x86 -tailcallopt | FileCheck %s
+; RUN: llc < %s -march=x86 -tailcallopt | grep TAILCALL
 define fastcc { { i8*, i8* }*, i8*} @init({ { i8*, i8* }*, i8*}, i32) {
 entry:
       %2 = tail call fastcc { { i8*, i8* }*, i8* } @init({ { i8*, i8*}*, i8*} %0, i32 %1)
       ret { { i8*, i8* }*, i8*} %2
-; CHECK: jmp init
 }

Modified: llvm/trunk/test/CodeGen/X86/tailcallbyval.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/tailcallbyval.ll?rev=175124&r1=175123&r2=175124&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/tailcallbyval.ll (original)
+++ llvm/trunk/test/CodeGen/X86/tailcallbyval.ll Wed Feb 13 21:00:57 2013
@@ -1,4 +1,5 @@
-; RUN: llc < %s -march=x86 -tailcallopt | FileCheck %s
+; RUN: llc < %s -march=x86 -tailcallopt | grep TAILCALL
+; RUN: llc < %s -march=x86 -tailcallopt | grep "movl[[:space:]]*4(%esp), %eax" | count 1
 %struct.s = type {i32, i32, i32, i32, i32, i32, i32, i32,
                   i32, i32, i32, i32, i32, i32, i32, i32,
                   i32, i32, i32, i32, i32, i32, i32, i32 }
@@ -8,15 +9,10 @@ entry:
         %tmp2 = getelementptr %struct.s* %a, i32 0, i32 0
         %tmp3 = load i32* %tmp2
         ret i32 %tmp3
-; CHECK: tailcallee
-; CHECK: movl 4(%esp), %eax
 }
 
 define  fastcc i32 @tailcaller(%struct.s* byval %a) nounwind {
 entry:
         %tmp4 = tail call fastcc i32 @tailcallee(%struct.s* byval %a )
         ret i32 %tmp4
-; CHECK: tailcaller
-; CHECK: jmp tailcallee
 }
-

Modified: llvm/trunk/test/CodeGen/X86/tailcallfp.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/tailcallfp.ll?rev=175124&r1=175123&r2=175124&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/tailcallfp.ll (original)
+++ llvm/trunk/test/CodeGen/X86/tailcallfp.ll Wed Feb 13 21:00:57 2013
@@ -1,6 +1,5 @@
-; RUN: llc < %s -march=x86 -tailcallopt | FileCheck %s
+; RUN: llc < %s -march=x86 -x86-asm-syntax=intel -tailcallopt | not grep call
 define fastcc i32 @bar(i32 %X, i32(double, i32) *%FP) {
      %Y = tail call fastcc i32 %FP(double 0.0, i32 %X)
      ret i32 %Y
-; CHECK: jmpl
 }

Modified: llvm/trunk/test/CodeGen/X86/tailcallpic1.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/tailcallpic1.ll?rev=175124&r1=175123&r2=175124&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/tailcallpic1.ll (original)
+++ llvm/trunk/test/CodeGen/X86/tailcallpic1.ll Wed Feb 13 21:00:57 2013
@@ -1,4 +1,4 @@
-; RUN: llc < %s  -tailcallopt -mtriple=i686-pc-linux-gnu -relocation-model=pic | FileCheck %s
+; RUN: llc < %s  -tailcallopt -mtriple=i686-pc-linux-gnu -relocation-model=pic | grep TAILCALL
 
 define protected fastcc i32 @tailcallee(i32 %a1, i32 %a2, i32 %a3, i32 %a4) {
 entry:
@@ -9,5 +9,4 @@ define fastcc i32 @tailcaller(i32 %in1,
 entry:
 	%tmp11 = tail call fastcc i32 @tailcallee( i32 %in1, i32 %in2, i32 %in1, i32 %in2 )		; <i32> [#uses=1]
 	ret i32 %tmp11
-; CHECK: jmp tailcallee
 }

Modified: llvm/trunk/test/CodeGen/X86/tailcallpic2.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/tailcallpic2.ll?rev=175124&r1=175123&r2=175124&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/tailcallpic2.ll (original)
+++ llvm/trunk/test/CodeGen/X86/tailcallpic2.ll Wed Feb 13 21:00:57 2013
@@ -1,4 +1,4 @@
-; RUN: llc < %s  -tailcallopt -mtriple=i686-pc-linux-gnu -relocation-model=pic | FileCheck %s
+; RUN: llc < %s  -tailcallopt -mtriple=i686-pc-linux-gnu -relocation-model=pic | grep -v TAILCALL
 
 define fastcc i32 @tailcallee(i32 %a1, i32 %a2, i32 %a3, i32 %a4) {
 entry:
@@ -9,7 +9,4 @@ define fastcc i32 @tailcaller(i32 %in1,
 entry:
 	%tmp11 = tail call fastcc i32 @tailcallee( i32 %in1, i32 %in2, i32 %in1, i32 %in2 )		; <i32> [#uses=1]
 	ret i32 %tmp11
-; CHECK: movl tailcallee at GOT
-; CHECK: jmpl
 }
-





More information about the llvm-commits mailing list