[llvm] r174834 - Handle string attributes in the AttrBuilder.

[Bill Wendling]

There will be a lot of tests coming. But right now it's not in a usable state until I can get the bit code updated (which should be in a day or two).

-bw

On Feb 10, 2013, at 8:33 AM, David Blaikie <dblaikie at gmail.com> wrote:

> 
> On Feb 10, 2013 2:15 AM, "Bill Wendling" <isanbard at gmail.com> wrote:
> >
> > Author: void
> > Date: Sun Feb 10 04:13:23 2013
> > New Revision: 174834
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=174834&view=rev
> > Log:
> > Handle string attributes in the AttrBuilder.
> 
> Tests? (This and your next commit)
> 
> >
> > Modified:
> >     llvm/trunk/lib/IR/Attributes.cpp
> >
> > Modified: llvm/trunk/lib/IR/Attributes.cpp
> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Attributes.cpp?rev=174834&r1=174833&r2=174834&view=diff
> > ==============================================================================
> > --- llvm/trunk/lib/IR/Attributes.cpp (original)
> > +++ llvm/trunk/lib/IR/Attributes.cpp Sun Feb 10 04:13:23 2013
> > @@ -879,7 +879,11 @@ AttrBuilder &AttrBuilder::addAttribute(A
> >  }
> >
> >  AttrBuilder &AttrBuilder::addAttribute(Attribute Attr) {
> > -  // FIXME: Handle string attributes.
> > +  if (Attr.isStringAttribute()) {
> > +    addAttribute(Attr.getKindAsString(), Attr.getValueAsString());
> > +    return *this;
> > +  }
> > +
> >    Attribute::AttrKind Kind = Attr.getKindAsEnum();
> >    Attrs.insert(Kind);
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130210/cc50fae1/attachment.html>