[llvm] r174717 - The patch to fix some issues in r174543 fixed the lines failing the test, but missed a couple

Tim Northover t.p.northover at gmail.com
Fri Feb 8 12:21:21 PST 2013


> The patch to fix some issues in r174543 fixed the lines failing the test, but missed a couple
> of lines which weren't being explicitly looked at and were printing incorrect results. These
> values clearly must lie within 32 bits, so the casts are definitely safe.

Strictly, the fields being printed are LEB128 which is arbitrary
precision. Practically, they may be 32-bit; but if that's a change
we're making it should probably be at the underlying storage level
rather than when dumping.

Unless the formats other than DWARF come into this, of course.

Tim.



More information about the llvm-commits mailing list