[llvm] r174574 - DWARFDebugFrame.cpp: Fix formatting on i686 hosts.

Eric Christopher echristo at gmail.com
Thu Feb 7 14:30:05 PST 2013


Yes, but ow. Try to avoid putting anything you know will break if we want
to try supporting DWARF64.

-eric


On Wed, Feb 6, 2013 at 8:43 PM, Eli Bendersky <eliben at google.com> wrote:

> On Wed, Feb 6, 2013 at 6:02 PM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
> > Author: chapuni
> > Date: Wed Feb  6 20:02:27 2013
> > New Revision: 174574
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=174574&view=rev
> > Log:
> > DWARFDebugFrame.cpp: Fix formatting on i686 hosts.
> >
> > FIXME: Are they really truncated to i32 from i64 unconditionally?
> >
>
> Thank you for the fix, Takumi. Semantically it's correct, since we
> don't currently support DWARF64 all such values are really 32-bits.
>
> > -    OS << format("%08x %08x %08x CIE", Offset, Length, DW_CIE_ID) <<
> "\n";
> > +    OS << format("%08x %08x %08x CIE",
> > +                 (uint32_t)Offset, (uint32_t)Length, DW_CIE_ID)
> > +       << "\n";
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130207/96b5027c/attachment.html>


More information about the llvm-commits mailing list