[PATCH,RFC] Re: [test-suite] / [LNT] debugging the handling of -maltivec in SingleSource/UnitTests/Vector/Altivec/Makefile

Will Schmidt will_schmidt at vnet.ibm.com
Thu Feb 7 12:53:25 PST 2013


On Thu, 2013-02-07 at 11:42 -0800, Daniel Dunbar wrote:

>         
>         Index: MultiSource/Makefile.multisrc
>         ===================================================================
>         --- MultiSource/Makefile.multisrc       (revision 174514)
>         +++ MultiSource/Makefile.multisrc       (working copy)
>         @@ -18,6 +18,9 @@
>         
>          include $(LEVEL)/Makefile.programs
>         
>         +# use X_TARGET_FLAGS to work around LNT behavior.
> 
> 
> It doesn't really have anything to do with LNT behavior, its make
> behavior. Probably better to just take the same comment from
> Makefile.tests.

Ok, will do.

> Actually, this variable definition should probably just get lifted to
> Makefile.programs, and then removed from all the other places.

Makes sense, I'll rework things and see if I can get another patch
turned around shortly. 
Thanks, 
-Will







More information about the llvm-commits mailing list