[llvm] r174543 - Add a test for checking the current .debug_frame dumping capability.

[David Blaikie]

On Wed, Feb 6, 2013 at 1:34 PM, Eli Bendersky <eliben at google.com> wrote:
> On Wed, Feb 6, 2013 at 1:28 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> On Wed, Feb 6, 2013 at 12:55 PM, Eli Bendersky <eliben at google.com> wrote:
>>> Author: eliben
>>> Date: Wed Feb  6 14:55:06 2013
>>> New Revision: 174543
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=174543&view=rev
>>> Log:
>>> Add a test for checking the current .debug_frame dumping capability.
>>>
>>> The test is a binary placed in test/DebugInfo/Inputs, with a source C
>>> file used for reference/reproducing. The source's first line is a clang
>>> build command for reproducing the binary.
>>
>> FWIW in other cases Eric & I have just been putting the source in
>> comments in the actual test file - makes it obvious. I probably
>> wouldn't think to look in other files to find the source the test case
>> was generated from. (though, admittedly, it is a little easier to
>> build the test case when the source is there, rather than having to
>> copy/paset it out, trim the comment characters, then compile it)
>
> Yes, exactly. Another thing is that in theory, a single input file can
> be exercised by several test scripts, in which case it isn't clear
> where to put that source.

At least a comment in any/all tests that depend on this saying "test
case generated from <relative path to test file here>" might be
helpful.