[llvm] r174485 - Failing builds because a private class member is not being used after

[Eli Bendersky]

On Tue, Feb 5, 2013 at 10:41 PM, Chandler Carruth <chandlerc at google.com> wrote:
> On Tue, Feb 5, 2013 at 9:37 PM, Eli Bendersky <eliben at google.com> wrote:
>>
>> Author: eliben
>> Date: Tue Feb  5 23:37:46 2013
>> New Revision: 174485
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=174485&view=rev
>> Log:
>> Failing builds because a private class member is not being used after
>> initialization is one of the reasons I consider -werror to be shoddy.
>
>
> This log doesn't really explain the change you made... Did the warning
> actually find that your commit didn't include intended code? Just trying to
> understand a bit better.
>

You're right - sorry about the grumpiness. I added a field to the
class, and initialized it, but I didn't add the code using it *yet*.
It was intentional. Having all the fields laid out in the class was
helpful for me to see what else is needed, etc. So even objectively I
don't like this by itself failing the bot.

Eli