[dragonegg] r174494 - It is normal that this test fails on x86-32. What is unclear is why it

[Duncan Sands]

Hi Bill, it looks like you changed the test in commit 174125:

   "Update test so that it gets the attribute before 'byval'"

-// CHECK: %struct.T* byval
+// CHECK: %struct.T* align 8 byval

The new check will only pass on x86-64.  This is OK, as the original problem was
on x86-64 only.

This commit didn't turn up in the buildbot blame list for some reason.

Anyway, everything is clear to me now, and there is nothing you need to worry
about!  I appreciate your trying to keep dragonegg chugging along :)

Ciao, Duncan.

On 06/02/13 09:22, Bill Wendling wrote:
> On Feb 6, 2013, at 12:13 AM, Duncan Sands <baldrick at free.fr> wrote:
>
>> Author: baldrick
>> Date: Wed Feb  6 02:13:40 2013
>> New Revision: 174494
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=174494&view=rev
>> Log:
>> It is normal that this test fails on x86-32.  What is unclear is why it
>> suddenly started failing...
>>
> It's a bit disconcerting that it's related to attributes...Do you know the check-in that caused this?
>
> -bw
>
>> Modified:
>>     dragonegg/trunk/test/validator/c++/x86-64-abi-sret-vs-2word-struct-param.cpp
>>
>> Modified: dragonegg/trunk/test/validator/c++/x86-64-abi-sret-vs-2word-struct-param.cpp
>> URL: http://llvm.org/viewvc/llvm-project/dragonegg/trunk/test/validator/c%2B%2B/x86-64-abi-sret-vs-2word-struct-param.cpp?rev=174494&r1=174493&r2=174494&view=diff
>> ==============================================================================
>> --- dragonegg/trunk/test/validator/c++/x86-64-abi-sret-vs-2word-struct-param.cpp (original)
>> +++ dragonegg/trunk/test/validator/c++/x86-64-abi-sret-vs-2word-struct-param.cpp Wed Feb  6 02:13:40 2013
>> @@ -1,7 +1,5 @@
>> // RUN: %dragonegg -S %s -o - | FileCheck %s
>> -// XTARGET: x86
>> -// PR4242
>> -// (PR 4242 bug is on 64-bit only, test passes on x86-32 as well)
>> +// XFAIL: i386, i486, i586, i686
>>
>> struct S {
>>      void* data[3];
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>