[llvm] r174482 - Tweak check to avoid integer overflow (for insanely large alignments)

Evan Cheng evan.cheng at apple.com
Tue Feb 5 18:06:33 PST 2013


Author: evancheng
Date: Tue Feb  5 20:06:33 2013
New Revision: 174482

URL: http://llvm.org/viewvc/llvm-project?rev=174482&view=rev
Log:
Tweak check to avoid integer overflow (for insanely large alignments)

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp?rev=174482&r1=174481&r2=174482&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp Tue Feb  5 20:06:33 2013
@@ -3520,7 +3520,7 @@ void SelectionDAGBuilder::visitAtomicLoa
 
   EVT VT = TLI.getValueType(I.getType());
 
-  if (I.getAlignment() * 8 < VT.getSizeInBits())
+  if (I.getAlignment() < VT.getSizeInBits() / 8)
     report_fatal_error("Cannot generate unaligned atomic load");
 
   SDValue L =
@@ -3550,7 +3550,7 @@ void SelectionDAGBuilder::visitAtomicSto
 
   EVT VT = TLI.getValueType(I.getValueOperand()->getType());
 
-  if (I.getAlignment() * 8 < VT.getSizeInBits())
+  if (I.getAlignment() < VT.getSizeInBits() / 8)
     report_fatal_error("Cannot generate unaligned atomic store");
 
   if (TLI.getInsertFencesForAtomic())





More information about the llvm-commits mailing list