[polly] r174365 - ScopDetect: clang-format pointer types in templates

[Daniel Jasper]

llvm.org/PR14747
llvm.org/PR15158

The decision (mostly by Chris and Douglas) is to put the spaces for
consistency.


On Tue, Feb 5, 2013 at 7:38 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Tue, Feb 5, 2013 at 3:56 AM, Tobias Grosser
> <grosser at fim.uni-passau.de> wrote:
> > Author: grosser
> > Date: Tue Feb  5 05:56:05 2013
> > New Revision: 174365
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=174365&view=rev
> > Log:
> > ScopDetect: clang-format pointer types in templates
> >
> > Modified:
> >     polly/trunk/lib/Analysis/ScopDetection.cpp
> >
> > Modified: polly/trunk/lib/Analysis/ScopDetection.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Analysis/ScopDetection.cpp?rev=174365&r1=174364&r2=174365&view=diff
> >
> ==============================================================================
> > --- polly/trunk/lib/Analysis/ScopDetection.cpp (original)
> > +++ polly/trunk/lib/Analysis/ScopDetection.cpp Tue Feb  5 05:56:05 2013
> > @@ -281,14 +281,14 @@ bool ScopDetection::isValidMemoryAccess(
> >
> >      OS << "Possible aliasing: ";
> >
> > -    std::vector<Value*> Pointers;
> > +    std::vector<Value *> Pointers;
>
> Daniel - have you had any discussion on this particular issue? (do
> LLVM developers have any opinions, too)
>
> I've often considered skipping the space in contexts where there is no
> identifier to bind the '*' to on the right hand side (so - template
> arguments, unnamed parameter declarations, etc). Right/wrong/meh?
>
> >
> >      for (AliasSet::iterator AI = AS.begin(), AE = AS.end(); AI != AE;
> ++AI)
> >        Pointers.push_back(AI.getPointer());
> >
> >      std::sort(Pointers.begin(), Pointers.end());
> >
> > -    for (std::vector<Value*>::iterator PI = Pointers.begin(),
> > +    for (std::vector<Value *>::iterator PI = Pointers.begin(),
> >                                          PE = Pointers.end();
> >           ;) {
> >        Value *V = *PI;
> > @@ -475,7 +475,7 @@ void ScopDetection::findScops(Region &R)
> >    // regions that form a Scop are not found. Therefore, those non
> canonical
> >    // regions are checked by expanding the canonical ones.
> >
> > -  std::vector<Region*> ToExpand;
> > +  std::vector<Region *> ToExpand;
> >
> >    for (Region::iterator I = R.begin(), E = R.end(); I != E; ++I)
> >      ToExpand.push_back(*I);
> > @@ -633,7 +633,7 @@ bool ScopDetection::runOnFunction(llvm::
> >
> >  void polly::ScopDetection::verifyRegion(const Region &R) const {
> >    assert(isMaxRegionInScop(R) && "Expect R is a valid region.");
> > -  DetectionContext Context(const_cast<Region&>(R), *AA, true
> /*verifying*/);
> > +  DetectionContext Context(const_cast<Region &>(R), *AA, true
> /*verifying*/);
> >    isValidRegion(Context);
> >  }
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130205/81a09667/attachment.html>