[llvm] r174442 - [mips] Do not use function CC_MipsN_VarArg unless the function being analyzed

Akira Hatanaka ahatanaka at mips.com
Tue Feb 5 13:18:11 PST 2013


Author: ahatanak
Date: Tue Feb  5 15:18:11 2013
New Revision: 174442

URL: http://llvm.org/viewvc/llvm-project?rev=174442&view=rev
Log:
[mips] Do not use function CC_MipsN_VarArg unless the function being analyzed
is a vararg function.

The original code was examining flag OutputArg::IsFixed to determine whether
CC_MipsN_VarArg or CC_MipsN should be called. This is not correct, since this
flag is often set to false when the function being analyzed is a non-variadic
function.

Added:
    llvm/trunk/test/CodeGen/Mips/mips64-expand-libcall.ll
Modified:
    llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp

Modified: llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp?rev=174442&r1=174441&r2=174442&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp Tue Feb  5 15:18:11 2013
@@ -3793,7 +3793,7 @@ MipsTargetLowering::MipsCC::MipsCC(Calli
     IntArgRegs = Mips64IntRegs;
     ShadowRegs = Mips64DPRegs;
     FixedFn = CC_MipsN;
-    VarFn = CC_MipsN_VarArg;
+    VarFn = IsVarArg ? CC_MipsN_VarArg : CC_MipsN;
   }
 
   if (CallConv == CallingConv::Fast) {

Added: llvm/trunk/test/CodeGen/Mips/mips64-expand-libcall.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Mips/mips64-expand-libcall.ll?rev=174442&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/Mips/mips64-expand-libcall.ll (added)
+++ llvm/trunk/test/CodeGen/Mips/mips64-expand-libcall.ll Tue Feb  5 15:18:11 2013
@@ -0,0 +1,14 @@
+; RUN: llc -march=mips64el -mcpu=mips64r2 -O3 < %s | FileCheck %s
+
+; Check that %add is not passed in an integer register.
+;
+; CHECK-NOT: dmfc1 $4
+
+define double @callfloor(double %d) nounwind readnone {
+entry:
+  %add = fadd double %d, 1.000000e+00
+  %call = tail call double @floor(double %add) nounwind readnone
+  ret double %call
+}
+
+declare double @floor(double) nounwind readnone





More information about the llvm-commits mailing list