[PATCH] More MSan/ASan annotations.

Kostya Serebryany kcc at google.com
Sun Feb 3 23:28:47 PST 2013


This is partially my fault because I LGTM-ed the final patch verbally w/o
doing it in email. Sorry.

--kcc


On Mon, Feb 4, 2013 at 11:22 AM, Chandler Carruth <chandlerc at gmail.com>wrote:

> On Sun, Feb 3, 2013 at 11:05 PM, Evgeniy Stepanov <eugenis at google.com>wrote:
>
>>
>>   Committed as r174306.
>>
>
> Evgeniy, this isn't OK.
>
> I know that you had an LGTM some time ago from Kostya, and have been
> waiting for review for some time, but committing due to silence isn't the
> right thing to do here. The right thing to do is to ping and complain and
> get someone to review it.
>
>
> I've reviewed the patch, and it LGTM so no need to revert or anything,
> just please wait until you get a review before committing next time.
> -Chandler
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130204/de60b63e/attachment.html>


More information about the llvm-commits mailing list