[PATCH 1/3] Add new keyword externally_initialized to LLVM.

Michael Gottesman mgottesman at apple.com
Thu Jan 31 22:03:10 PST 2013


Updated patch with wording suggested by John McCall:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Updated-LangRef-to-support-the-marker-externally_ini.patch
Type: application/octet-stream
Size: 1354 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130131/7c0d7482/attachment.obj>
-------------- next part --------------


Please Review!

Michael

On Jan 31, 2013, at 10:57 AM, Michael Gottesman <mgottesman at apple.com> wrote:

> Hello LLVM Commits!
> 
> As decided in the email thread "[llvm-commits] [PATCH] Miscompile Fix: Ensure that we do not constant fold Globals containing ObjC References in GlobalOpt", we need a new keyword to represent the notion of a global variable that may be initialized at run time before user code is run by some ``external'' mechanism. Thus I propose we call said keyword ``externally_intialized''. This is the first of 3 patches to implement said keyword.
> 
> As a guide, the patches are organized as follows:
> 
> 1. Add externally_initialized to LangRef.
> 2. Add support for externally_initialized to GlobalVariable via a boolean variable.
> 3. Add support to the llvm IR assembly writer/reader and the llvm IR bit code writer/reader to support reading/writing ``externally_initialized''.
> 
> Here is the first patch:
> 
> <0001-Updated-LangRef-to-support-the-marker-externally_ini.patch>
> 
> Any pitchforks are appreciated. Please Review!
> 
> Michael
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list