[llvm] r174116 - s/AttrBuilder::addAttributes/AttrBuilder::addAttribute/g because that's more descriptive of what it actually is.

Bill Wendling isanbard at gmail.com
Thu Jan 31 15:38:01 PST 2013


Author: void
Date: Thu Jan 31 17:38:01 2013
New Revision: 174116

URL: http://llvm.org/viewvc/llvm-project?rev=174116&view=rev
Log:
s/AttrBuilder::addAttributes/AttrBuilder::addAttribute/g because that's more descriptive of what it actually is.

Modified:
    llvm/trunk/include/llvm/IR/Attributes.h
    llvm/trunk/lib/IR/Attributes.cpp

Modified: llvm/trunk/include/llvm/IR/Attributes.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/Attributes.h?rev=174116&r1=174115&r2=174116&view=diff
==============================================================================
--- llvm/trunk/include/llvm/IR/Attributes.h (original)
+++ llvm/trunk/include/llvm/IR/Attributes.h Thu Jan 31 17:38:01 2013
@@ -345,7 +345,7 @@ public:
     addRawValue(B);
   }
   AttrBuilder(const Attribute &A) : Alignment(0), StackAlignment(0) {
-    addAttributes(A);
+    addAttribute(A);
   }
   AttrBuilder(AttributeSet AS, unsigned Idx);
 
@@ -354,12 +354,12 @@ public:
   /// \brief Add an attribute to the builder.
   AttrBuilder &addAttribute(Attribute::AttrKind Val);
 
+  /// \brief Add the Attribute object to the builder.
+  AttrBuilder &addAttribute(Attribute A);
+
   /// \brief Remove an attribute from the builder.
   AttrBuilder &removeAttribute(Attribute::AttrKind Val);
 
-  /// \brief Add the attributes to the builder.
-  AttrBuilder &addAttributes(Attribute A);
-
   /// \brief Remove the attributes from the builder.
   AttrBuilder &removeAttributes(AttributeSet A, uint64_t Index);
 

Modified: llvm/trunk/lib/IR/Attributes.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Attributes.cpp?rev=174116&r1=174115&r2=174116&view=diff
==============================================================================
--- llvm/trunk/lib/IR/Attributes.cpp (original)
+++ llvm/trunk/lib/IR/Attributes.cpp Thu Jan 31 17:38:01 2013
@@ -437,7 +437,7 @@ uint64_t AttributeSetImpl::Raw(uint64_t 
 
     for (AttributeSetNode::const_iterator II = ASN->begin(),
            IE = ASN->end(); II != IE; ++II)
-      B.addAttributes(*II);
+      B.addAttribute(*II);
     return B.Raw();
   }
 
@@ -596,7 +596,7 @@ AttributeSet AttributeSet::addAttributes
     if (Attrs.getSlotIndex(I) == Idx) {
       for (AttributeSetImpl::const_iterator II = Attrs.pImpl->begin(I),
              IE = Attrs.pImpl->end(I); II != IE; ++II)
-        B.addAttributes(*II);
+        B.addAttribute(*II);
       break;
     }
 
@@ -798,7 +798,7 @@ AttrBuilder::AttrBuilder(AttributeSet AS
 
     for (AttributeSetImpl::const_iterator II = pImpl->begin(I),
            IE = pImpl->end(I); II != IE; ++II)
-      addAttributes(*II);
+      addAttribute(*II);
 
     break;
   }
@@ -816,18 +816,7 @@ AttrBuilder &AttrBuilder::addAttribute(A
   return *this;
 }
 
-AttrBuilder &AttrBuilder::removeAttribute(Attribute::AttrKind Val) {
-  Attrs.erase(Val);
-
-  if (Val == Attribute::Alignment)
-    Alignment = 0;
-  else if (Val == Attribute::StackAlignment)
-    StackAlignment = 0;
-
-  return *this;
-}
-
-AttrBuilder &AttrBuilder::addAttributes(Attribute Attr) {
+AttrBuilder &AttrBuilder::addAttribute(Attribute Attr) {
   ConstantInt *Kind = cast<ConstantInt>(Attr.getAttributeKind());
   Attribute::AttrKind KindVal = Attribute::AttrKind(Kind->getZExtValue());
   Attrs.insert(KindVal);
@@ -839,6 +828,17 @@ AttrBuilder &AttrBuilder::addAttributes(
   return *this;
 }
 
+AttrBuilder &AttrBuilder::removeAttribute(Attribute::AttrKind Val) {
+  Attrs.erase(Val);
+
+  if (Val == Attribute::Alignment)
+    Alignment = 0;
+  else if (Val == Attribute::StackAlignment)
+    StackAlignment = 0;
+
+  return *this;
+}
+
 AttrBuilder &AttrBuilder::removeAttributes(AttributeSet A, uint64_t Index) {
   uint64_t Mask = A.Raw(Index);
 





More information about the llvm-commits mailing list