[PATCH] LangRef: Clarify expectations of volatile ld/st vs volatile intrinsics.

Andrew Trick atrick at apple.com
Wed Jan 30 16:51:41 PST 2013


On Jan 30, 2013, at 1:29 PM, Sean Silva <silvas at purdue.edu> wrote:

> On Wed, Jan 30, 2013 at 4:20 PM, Andrew Trick <atrick at apple.com> wrote:
>> Thanks for the feedback. I moved the commentary to the commit log with your edits.
>> Committed r173974.
>> -Andy
> 
> Please keep the rationale with it!
> 
> reStructuredText does have footnotes, see
> <http://sphinx-doc.org/rest.html#footnotes>.
> 
> Another possibility is to use:
> 
> .. admonition:: Rationale
> 
>   Explanation of the rationale.
> 
> You can see that in action in
> <http://clang.llvm.org/docs/AutomaticReferenceCounting.html#retainable-object-pointers>
> (although LLVM's stylesheet is different and makes the plain
> admonition stand out a bit more).


Thanks. Fixed in r174007.

If anyone wants to make minor improvements to the wording, just go right ahead.

-Andy



More information about the llvm-commits mailing list