[zorg] r173940 - Fix for lines of the type: \* TEST '.' FAILED \*

[David Dean]

On 30 Jan 2013, at 11:39 AM, David Blaikie <dblaikie at gmail.com> wrote:

> Does this actually work? I would assume it would fail to match the
> kTestFailureLogStartRE pattern:

The case that was failing was in a simple make check style, but I'm not sure why they didn't match the pattern. Did the pattern change some time ago? I'm seeing it on a branch from a couple of months ago.

The values from debugging it were:
m.group(0): "******************** TEST 'LLVM :: CodeGen/CellSPU/call.ll' FAILED ********************"
inFailure[0]: 'LLVM :: CodeGen/CellSPU/call.ll'

So I think it's the logic that was wrong, not the expression.
If you want to go with the equality check. This would make more sense to me:
> m.group(2) == self.inFailure[0]


and should work because I believe that this would be the values here:

m.group(0): "******************** TEST 'LLVM :: CodeGen/CellSPU/call.ll' FAILED ********************"
m.group(1): "******************** TEST 
m.group(2): 'LLVM :: CodeGen/CellSPU/call.ll'
m.group(3):  FAILED ********************"

-David