[PATCH] fix llvm linker issue with dbg.declare

Eric Christopher echristo at gmail.com
Wed Jan 30 10:54:36 PST 2013


The two people who have been in the linker code the most are Bill and
Chris, both of whom sit within meters of you...

-eric


On Wed, Jan 30, 2013 at 9:44 AM, Manman Ren <mren at apple.com> wrote:

>
> Hi all,
>
> Since I got no response on this patch and we need this patch soon, I
> committed at r173946.
> If you have any concern about this patch, please review after commit.
>
> Thanks,
> Manman
>
> On Jan 29, 2013, at 2:01 PM, Manman Ren <mren at apple.com> wrote:
>
> >
> > ping
> >
> > Thanks,
> > Manman
> >
> > On Jan 28, 2013, at 3:21 PM, Manman Ren <mren at apple.com> wrote:
> >
> >>
> >> Hello,
> >>
> >> Given source IR:
> >> call void @llvm.dbg.declare(metadata !{i32* %argc.addr}, metadata !14),
> !dbg !15
> >> we used to generate
> >> call void @llvm.dbg.declare(metadata !27, metadata !28), !dbg !29
> >> !27 = metadata !{null}
> >>
> >> With this patch, we will generate
> >> call void @llvm.dbg.declare(metadata !{i32* %argc.addr}, metadata !27),
> !dbg !28
> >>
> >> Looking up %argc.addr in ValueMap will return null. Since %argc.addr is
> already
> >> correctly set up, we can use identity mapping.
> >>
> >> Please review,
> >>
> >> Thanks,
> >> Manman
> >>
> >> <linker.patch>_______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130130/ec89ad31/attachment.html>


More information about the llvm-commits mailing list