Fwd: [PATCH] fix llvm linker issue with dbg.declare

[Eli Bendersky]

>> Since I got no response on this patch and we need this patch soon, I committed at r173946.
>
> Manman,
> It may have been best to continue pressing for a review first.
>

Yes.

>>> If you have any concern about this patch, please review after commit.
>>>
>>
>> Ah, it's good to know there is a new patch review policy for LLVM.
>> Thanks, Manman.
>
> Eli,
> What was the point of this comment?

The point was to express the same thing you said above. The sarcastic
tone may have been uncalled for, but stems from bitter experience.
Having had the pleasure (on multiple occasions  for multiple code
areas) to chase code owners for weeks with multiple list & IRC pings
before getting the LGTM, it hurts to see the honor code broken by a
review-less commit made less than 48 hours after the initial request,
because "we need this patch soon".

Eli