[PATCH] [hexagon] remove sxth after max with two halfword operands

Jyotsna Verma jverma at codeaurora.org
Wed Jan 30 08:10:03 PST 2013


Ikhlas,

The patch looks good to me except for one issue. You have added a new
predicate 'PositiveHalfWord' in lib/Target/Hexagon/HexagonRegisterInfo.td.
Can you please move it to lib/Target/Hexagon/HexagonOperands.td along with
other predicates?

Thanks,
Jyotsna
 
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

> -----Original Message-----
> From: Ikhlas Ajbar [mailto:iajbar at codeaurora.org]
> Sent: Tuesday, January 29, 2013 9:55 PM
> To: llvm-commits at cs.uiuc.edu
> Cc: iajbar at codeaurora.org; jverma at codeaurora.org;
> adasgupt at codeaurora.org
> Subject: [PATCH] [hexagon] remove sxth after max with two halfword
> operands
> 
> Hello,
> 
> The attached patch improves the way min and max instructions are
> generated to recognize more patterns. In particular, this patch was needed
> to remove a sign extend halfword "sxth" after a max with two halfword
> operands: testcases attached.
> 
> Tested on x86-linux with make check. Could you please review the patch?
> 
> Thanks,
> Ikhlas




More information about the llvm-commits mailing list