[llvm-commits] [PATCH] Documentation: Fix Datalayout defaults documentation.

[Patrik Hägglund H]

> Can someone check that my interpretation of DataLayout::init() is correct and (assuming so) commit the patch?

LGTM! Commited as r173914. Thanks!

/Patrik Hägglund

From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Stephen McGruer
Sent: den 20 januari 2013 12:29
To: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [PATCH] Documentation: Fix Datalayout defaults documentation.

Ping.

No changes to Datalayout.cpp between the 4th and now, so the patch should still be good. (As long as my interpretation of DataLayout::init() is right!)

On 4 January 2013 19:23, Stephen McGruer <stephen.mcgruer at gmail.com<mailto:stephen.mcgruer at gmail.com>> wrote:
(Ping, and changed subject to llvm-commits style.)

This patch updates the LangRef documentation to correctly describe the default datalayout string. The current documentation (http://llvm.org/docs/LangRef.html#data-layout) and DataLayout::init() (http://llvm.org/docs/doxygen/html/DataLayout_8cpp_source.html#l00154) disagree on a number of points.

Can someone check that my interpretation of DataLayout::init() is correct and (assuming so) commit the patch?

A full description can be found at http://llvm.org/bugs/show_bug.cgi?id=14673.

Stephen

---------- Forwarded message ----------
From: Stephen McGruer <stephen.mcgruer at gmail.com<mailto:stephen.mcgruer at gmail.com>>
Date: 21 December 2012 14:26
Subject: Patch for bug 14673 (Mismatchs between Datalayout documentation and code)
To: llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>

Dear all,

This patch updates the LangRef documentation to correctly describe the default datalayout string in LLVM. The current listing has a number of inaccuracies, the most important of which is probably the mistaken statement that aggregate alignment defaults to a0:0:1, instead of the true a0:0:64.

Full description at http://llvm.org/bugs/show_bug.cgi?id=14673.

Stephen


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130130/2a626a7f/attachment.html>