[llvm-commits] [PATCH] Dwarf: support for LTO where a single object file can have multiple line tables

Kevin Enderby enderby at apple.com
Mon Jan 28 15:48:22 PST 2013


The include/llvm/MC/* and the lib/MC/MCcontext.cpp changes look good to me as I think I was the one that may have done the initial implementation of the dward line table stuff in there.

I can't speak to the lib/CodeGen changes as they are out of my area.  Maybe Eric can look at that part.

Kev

On Jan 28, 2013, at 3:21 PM, Manman Ren <mren at apple.com> wrote:

> 
> PING with updated patch.
> 
> <line_table.patch>
> On Jan 25, 2013, at 4:05 PM, Manman Ren <mren at apple.com> wrote:
> 
>> 
>> Hello,
>> 
>> With LTO, we will generate a single object file with multiple compilation units, and we used to generate a single combined line table
>> and all compilation units will point to the same line table.
>> 
>> With this patch, we will generate one line table for each compilation unit in the object file.
>> 
>> Added the following members in MCContext:
>> +    /// The Compile Unit ID that we are currently processing.
>> +    int DwarfCompileUnitID;
>> +    /// The line table start symbol for each Compile Unit.
>> +    DenseMap<int, MCSymbol *> MCLineTableSymbols;
>> Modified members in MCLineSection:
>> -    MCLineEntryCollection MCLineEntries;
>> +    // A collection of MCLineEntry for each Compile Unit ID.
>> +    DenseMap<int, MCLineEntryCollection> MCLineDivisions;
>> 
>> Please review,
>> 
>> Thanks,
>> Manman
>> <line_table.patch>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list