[llvm-commits] [llvm] r173649 - Make some code a little simpler.
David Blaikie
dblaikie at gmail.com
Mon Jan 28 12:12:01 PST 2013
On Mon, Jan 28, 2013 at 12:06 PM, Reed Kotler <rkotler at mips.com> wrote:
> Curious as to how you are building where warnings are errors?
>
> I guess I should be doing the same before putback if the rest of the tree is
> clean in that way.
We usually keep the Clang/LLVM build warning-clean with Clang at
least. Many of us use a pre-built Clang from some recent revision as
the compiler we use to build our development version & we configure
our builds to use -Werror to catch these sort of things as soon as
possible.
>
>
> On 01/27/2013 09:54 PM, Craig Topper wrote:
>
> I think this left addToNoHelperNeeded as an used function.
>
> lib/Target/Mips/MipsISelLowering.cpp:218:15: error: unused function
> 'addToNoHelperNeeded' [-Werror,-Wunused-function]
> const char* addToNoHelperNeeded(const char* s) {
>
> On Sun, Jan 27, 2013 at 6:46 PM, Reed Kotler <rkotler at mips.com> wrote:
>>
>> Author: rkotler
>> Date: Sun Jan 27 20:46:49 2013
>> New Revision: 173649
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=173649&view=rev
>> Log:
>> Make some code a little simpler.
>>
>>
>> Modified:
>> llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
>> llvm/trunk/lib/Target/Mips/MipsISelLowering.h
>>
>> Modified: llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp?rev=173649&r1=173648&r2=173649&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp (original)
>> +++ llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp Sun Jan 27 20:46:49
>> 2013
>> @@ -222,47 +222,45 @@ namespace {
>>
>> }
>>
>> +void MipsTargetLowering::SetMips16LibcallName
>> + (RTLIB::Libcall l, const char *Name) {
>> + setLibcallName(l, Name);
>> + noHelperNeeded.insert(Name);
>> +}
>> +
>> void MipsTargetLowering::setMips16HardFloatLibCalls() {
>> - setLibcallName(RTLIB::ADD_F32, addToNoHelperNeeded("__mips16_addsf3"));
>> - setLibcallName(RTLIB::ADD_F64, addToNoHelperNeeded("__mips16_adddf3"));
>> - setLibcallName(RTLIB::SUB_F32, addToNoHelperNeeded("__mips16_subsf3"));
>> - setLibcallName(RTLIB::SUB_F64, addToNoHelperNeeded("__mips16_subdf3"));
>> - setLibcallName(RTLIB::MUL_F32, addToNoHelperNeeded("__mips16_mulsf3"));
>> - setLibcallName(RTLIB::MUL_F64, addToNoHelperNeeded("__mips16_muldf3"));
>> - setLibcallName(RTLIB::DIV_F32, addToNoHelperNeeded("__mips16_divsf3"));
>> - setLibcallName(RTLIB::DIV_F64, addToNoHelperNeeded("__mips16_divdf3"));
>> - setLibcallName(RTLIB::FPEXT_F32_F64,
>> - addToNoHelperNeeded("__mips16_extendsfdf2"));
>> - setLibcallName(RTLIB::FPROUND_F64_F32,
>> - addToNoHelperNeeded("__mips16_truncdfsf2"));
>> - setLibcallName(RTLIB::FPTOSINT_F32_I32,
>> - addToNoHelperNeeded("__mips16_fix_truncsfsi"));
>> - setLibcallName(RTLIB::FPTOSINT_F64_I32,
>> - addToNoHelperNeeded("__mips16_fix_truncdfsi"));
>> - setLibcallName(RTLIB::SINTTOFP_I32_F32,
>> - addToNoHelperNeeded("__mips16_floatsisf"));
>> - setLibcallName(RTLIB::SINTTOFP_I32_F64,
>> - addToNoHelperNeeded("__mips16_floatsidf"));
>> - setLibcallName(RTLIB::UINTTOFP_I32_F32,
>> - addToNoHelperNeeded("__mips16_floatunsisf"));
>> - setLibcallName(RTLIB::UINTTOFP_I32_F64,
>> - addToNoHelperNeeded("__mips16_floatunsidf"));
>> - setLibcallName(RTLIB::OEQ_F32, addToNoHelperNeeded("__mips16_eqsf2"));
>> - setLibcallName(RTLIB::OEQ_F64, addToNoHelperNeeded("__mips16_eqdf2"));
>> - setLibcallName(RTLIB::UNE_F32, addToNoHelperNeeded("__mips16_nesf2"));
>> - setLibcallName(RTLIB::UNE_F64, addToNoHelperNeeded("__mips16_nedf2"));
>> - setLibcallName(RTLIB::OGE_F32, addToNoHelperNeeded("__mips16_gesf2"));
>> - setLibcallName(RTLIB::OGE_F64, addToNoHelperNeeded("__mips16_gedf2"));
>> - setLibcallName(RTLIB::OLT_F32, addToNoHelperNeeded("__mips16_ltsf2"));
>> - setLibcallName(RTLIB::OLT_F64, addToNoHelperNeeded("__mips16_ltdf2"));
>> - setLibcallName(RTLIB::OLE_F32, addToNoHelperNeeded("__mips16_lesf2"));
>> - setLibcallName(RTLIB::OLE_F64, addToNoHelperNeeded("__mips16_ledf2"));
>> - setLibcallName(RTLIB::OGT_F32, addToNoHelperNeeded("__mips16_gtsf2"));
>> - setLibcallName(RTLIB::OGT_F64, addToNoHelperNeeded("__mips16_gtdf2"));
>> - setLibcallName(RTLIB::UO_F32,
>> addToNoHelperNeeded("__mips16_unordsf2"));
>> - setLibcallName(RTLIB::UO_F64,
>> addToNoHelperNeeded("__mips16_unorddf2"));
>> - setLibcallName(RTLIB::O_F32, addToNoHelperNeeded("__mips16_unordsf2"));
>> - setLibcallName(RTLIB::O_F64, addToNoHelperNeeded("__mips16_unorddf2"));
>> + SetMips16LibcallName(RTLIB::ADD_F32, "__mips16_addsf3");
>> + SetMips16LibcallName(RTLIB::ADD_F64, "__mips16_adddf3");
>> + SetMips16LibcallName(RTLIB::SUB_F32, "__mips16_subsf3");
>> + SetMips16LibcallName(RTLIB::SUB_F64, "__mips16_subdf3");
>> + SetMips16LibcallName(RTLIB::MUL_F32, "__mips16_mulsf3");
>> + SetMips16LibcallName(RTLIB::MUL_F64, "__mips16_muldf3");
>> + SetMips16LibcallName(RTLIB::DIV_F32, "__mips16_divsf3");
>> + SetMips16LibcallName(RTLIB::DIV_F64, "__mips16_divdf3");
>> + SetMips16LibcallName(RTLIB::FPEXT_F32_F64, "__mips16_extendsfdf2");
>> + SetMips16LibcallName(RTLIB::FPROUND_F64_F32, "__mips16_truncdfsf2");
>> + SetMips16LibcallName(RTLIB::FPTOSINT_F32_I32,
>> "__mips16_fix_truncsfsi");
>> + SetMips16LibcallName(RTLIB::FPTOSINT_F64_I32,
>> "__mips16_fix_truncdfsi");
>> + SetMips16LibcallName(RTLIB::SINTTOFP_I32_F32, "__mips16_floatsisf");
>> + SetMips16LibcallName(RTLIB::SINTTOFP_I32_F64, "__mips16_floatsidf");
>> + SetMips16LibcallName(RTLIB::UINTTOFP_I32_F32, "__mips16_floatunsisf");
>> + SetMips16LibcallName(RTLIB::UINTTOFP_I32_F64, "__mips16_floatunsidf");
>> + SetMips16LibcallName(RTLIB::OEQ_F32, "__mips16_eqsf2");
>> + SetMips16LibcallName(RTLIB::OEQ_F64, "__mips16_eqdf2");
>> + SetMips16LibcallName(RTLIB::UNE_F32, "__mips16_nesf2");
>> + SetMips16LibcallName(RTLIB::UNE_F64, "__mips16_nedf2");
>> + SetMips16LibcallName(RTLIB::OGE_F32, "__mips16_gesf2");
>> + SetMips16LibcallName(RTLIB::OGE_F64, "__mips16_gedf2");
>> + SetMips16LibcallName(RTLIB::OLT_F32, "__mips16_ltsf2");
>> + SetMips16LibcallName(RTLIB::OLT_F64, "__mips16_ltdf2");
>> + SetMips16LibcallName(RTLIB::OLE_F32, "__mips16_lesf2");
>> + SetMips16LibcallName(RTLIB::OLE_F64, "__mips16_ledf2");
>> + SetMips16LibcallName(RTLIB::OGT_F32, "__mips16_gtsf2");
>> + SetMips16LibcallName(RTLIB::OGT_F64, "__mips16_gtdf2");
>> + SetMips16LibcallName(RTLIB::UO_F32, "__mips16_unordsf2");
>> + SetMips16LibcallName(RTLIB::UO_F64, "__mips16_unorddf2");
>> + SetMips16LibcallName(RTLIB::O_F32, "__mips16_unordsf2");
>> + SetMips16LibcallName(RTLIB::O_F64, "__mips16_unorddf2");
>> }
>>
>> MipsTargetLowering::
>>
>> Modified: llvm/trunk/lib/Target/Mips/MipsISelLowering.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.h?rev=173649&r1=173648&r2=173649&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/Target/Mips/MipsISelLowering.h (original)
>> +++ llvm/trunk/lib/Target/Mips/MipsISelLowering.h Sun Jan 27 20:46:49 2013
>> @@ -176,6 +176,8 @@ namespace llvm {
>> virtual SDValue PerformDAGCombine(SDNode *N, DAGCombinerInfo &DCI)
>> const;
>> private:
>>
>> + void SetMips16LibcallName(RTLIB::Libcall, const char *Name);
>> +
>> void setMips16HardFloatLibCalls();
>>
>> unsigned int
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
>
> --
> ~Craig
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
More information about the llvm-commits
mailing list