[llvm-commits] [llvm] r173674 - Fix 256-bit PALIGNR comment decoding to understand that it works on independent 256-bit lanes.

[Craig Topper]

Oops. That should have said "128-bit lanes."

On Sun, Jan 27, 2013 at 11:41 PM, Craig Topper <craig.topper at gmail.com>wrote:

> Author: ctopper
> Date: Mon Jan 28 01:41:18 2013
> New Revision: 173674
>
> URL: http://llvm.org/viewvc/llvm-project?rev=173674&view=rev
> Log:
> Fix 256-bit PALIGNR comment decoding to understand that it works on
> independent 256-bit lanes.
>
> Modified:
>     llvm/trunk/lib/Target/X86/Utils/X86ShuffleDecode.cpp
>     llvm/trunk/test/MC/X86/shuffle-comments.s
>
> Modified: llvm/trunk/lib/Target/X86/Utils/X86ShuffleDecode.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/Utils/X86ShuffleDecode.cpp?rev=173674&r1=173673&r2=173674&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/Utils/X86ShuffleDecode.cpp (original)
> +++ llvm/trunk/lib/Target/X86/Utils/X86ShuffleDecode.cpp Mon Jan 28
> 01:41:18 2013
> @@ -66,8 +66,17 @@ void DecodePALIGNRMask(MVT VT, unsigned
>    unsigned NumElts = VT.getVectorNumElements();
>    unsigned Offset = Imm * (VT.getVectorElementType().getSizeInBits() / 8);
>
> -  for (unsigned i = 0; i != NumElts; ++i)
> -    ShuffleMask.push_back((i + Offset) % (NumElts * 2));
> +  unsigned NumLanes = VT.getSizeInBits() / 128;
> +  unsigned NumLaneElts = NumElts / NumLanes;
> +
> +  for (unsigned l = 0; l != NumElts; l += NumLaneElts) {
> +    for (unsigned i = 0; i != NumLaneElts; ++i) {
> +      unsigned Base = i + Offset;
> +      // if i+offset is out of this lane then we actually need the other
> source
> +      if (Base >= NumLaneElts) Base += NumElts - NumLaneElts;
> +      ShuffleMask.push_back(Base + l);
> +    }
> +  }
>  }
>
>  /// DecodePSHUFMask - This decodes the shuffle masks for pshufd, and
> vpermilp*.
>
> Modified: llvm/trunk/test/MC/X86/shuffle-comments.s
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/X86/shuffle-comments.s?rev=173674&r1=173673&r2=173674&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/MC/X86/shuffle-comments.s (original)
> +++ llvm/trunk/test/MC/X86/shuffle-comments.s Mon Jan 28 01:41:18 2013
> @@ -29,3 +29,18 @@ vpalignr $0, %xmm0, %xmm1, %xmm2
>  # CHECK: xmm2 = xmm0[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15]
>  vpalignr $0, (%rax), %xmm1, %xmm2
>  # CHECK: xmm2 = mem[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15]
> +
> +vpalignr $8, %ymm0, %ymm1, %ymm2
> +# CHECK: ymm2 =
> ymm0[8,9,10,11,12,13,14,15],ymm1[0,1,2,3,4,5,6,7],ymm0[24,25,26,27,28,29,30,31],ymm1[16,17,18,19,20,21,22,23]
> +vpalignr $8, (%rax), %ymm1, %ymm2
> +# CHECK: ymm2 =
> mem[8,9,10,11,12,13,14,15],ymm1[0,1,2,3,4,5,6,7],mem[24,25,26,27,28,29,30,31],ymm1[16,17,18,19,20,21,22,23]
> +
> +vpalignr $16, %ymm0, %ymm1, %ymm2
> +# CHECK: ymm2 =
> ymm1[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31]
> +vpalignr $16, (%rax), %ymm1, %ymm2
> +# CHECK: ymm2 =
> ymm1[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31]
> +
> +vpalignr $0, %ymm0, %ymm1, %ymm2
> +# CHECK: ymm2 =
> ymm0[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31]
> +vpalignr $0, (%rax), %ymm1, %ymm2
> +# CHECK: ymm2 =
> mem[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31]
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130127/d649cc3b/attachment.html>