[llvm-commits] [llvm] r173509 - /llvm/trunk/test/Other/close-stderr.ll

[Reid Kleckner]

I happen to have Cygwin bash on my PATH, so shell is true, but I've found
that manually setting 'execute_external = False' in lit.cfg lets me run far
more of the test suite.  Perhaps I should remove the shell feature in that
case.

However, I don't think this test can work at all on Windows, unless
TestRunner.py tries harder to replace /dev/null.  The command line is 'opt
-o /dev/null /dev/null 2>&-', and opt knows nothing about /dev/null, right?
 For me that file does not exist and I get a non-zero return code for the
second opt invocation.


On Fri, Jan 25, 2013 at 6:47 PM, NAKAMURA Takumi <geek4civic at gmail.com>wrote:

> Reid, I suppose it has been disabled with "REQUIRES:shell" on win32
> (includes msvc).
> What is your motivation on this commit?
>
> FYI, it has been working with mingw32 msys bash.
>
> ...Takumi
>
> 2013/1/26 Reid Kleckner <reid at kleckner.net>:
> > Author: rnk
> > Date: Fri Jan 25 16:12:54 2013
> > New Revision: 173509
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=173509&view=rev
> > Log:
> > XFAIL close-stderr on win32
> >
> > The test runner does not rewrite instances of /dev/null inside the
> > quoted sh command.  /dev/null does not exist, so opt will fail to open
> > it, and return a non-zero exit code.
> >
> > Modified:
> >     llvm/trunk/test/Other/close-stderr.ll
> >
> > Modified: llvm/trunk/test/Other/close-stderr.ll
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/close-stderr.ll?rev=173509&r1=173508&r2=173509&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/test/Other/close-stderr.ll (original)
> > +++ llvm/trunk/test/Other/close-stderr.ll Fri Jan 25 16:12:54 2013
> > @@ -9,5 +9,8 @@
> >  ; XFAIL: vg_leak
> >  ; REQUIRES: shell
> >
> > +; opt will fail to open /dev/null on native win32.
> > +; XFAIL: win32
> > +
> >  ; Test that the error handling when writing to stderr fails exits the
> >  ; program cleanly rather than aborting.
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130126/6af62875/attachment.html>