[llvm-commits] [PATCH]: POC patch for specifying which sections to dump in llvm-dwarfdump

[Eli Bendersky]

On Thu, Jan 24, 2013 at 4:28 PM, Eric Christopher <echristo at gmail.com> wrote:
> Pretty good with the basic idea, few comments:
>
> -  OwningPtr<DIContext> dictx(DIContext::getDWARFContext(Obj.get()));
> +  OwningPtr<DIContext> DICtx(DIContext::getDWARFContext(Obj.get()));
>
> Seems somewhat gratuitous.
>

There were two reasons for this change:

1. General coding conventions consistency.
2. The first couple of times I saw that variable I had a slight wtf
moment reading it "dict x" and getting confused. (yeah, too much
Python, I know).

However, I don't see it as a big deal, so if you feel strongly about
keeping the old name, I'll remove it from the patch. No worries.


> +void DWARFContext::dump(raw_ostream &OS, DIDumpType DumpType) {
>
> I'd kind of like this to have DumpType with a default arg of all.
>

OK. I had this default value for the DIContext interface; will add for
DWARFContext as well.

> For a list of options I'd take start with one per section name (including
> the dwo sections).
>

Yep, this is the direction I'm aiming at.

> Needs tests.

Will add.