[llvm-commits] Cost Table, take 3

Renato Golin renato.golin at linaro.org
Thu Jan 24 15:01:50 PST 2013


Committed on r173382.

Thanks!


On 24 January 2013 22:35, Chandler Carruth <chandlerc at google.com> wrote:

> On Jan 24, 2013 2:09 PM, "Renato Golin" <renato.golin at linaro.org> wrote:
>
>> Now, in include/llvm/Target
>>
>
> Oh, please go ahead and submit. =] LGTM. I meant the prior message to
> indicate you should submit with the header file move (which ever one seemed
> to work best).
>
>
>>
>> cheers,
>> --renato
>>
>>
>> On 24 January 2013 21:53, Renato Golin <renato.golin at linaro.org> wrote:
>>
>>> On 24 January 2013 21:06, Chandler Carruth <chandlerc at google.com> wrote:
>>>
>>>> This code (and your plan) makes perfect sense to me.
>>>>
>>>> I would suggest putting it in its own header, or in some other header
>>>> under include/llvm/Target --- the consumers of the analysis aren't the ones
>>>> that want it.
>>>>
>>>
>>> I looked for a better header on Target, but there was none, and since it
>>> was an exclusive TransformInfo issue, I thought creating a new header on
>>> Target would be too much. But it makes sense, even if a really small
>>> header, won't be on the wrong place.
>>>
>>> Will change.
>>>
>>> cheers,
>>> --renato
>>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130124/ed471de6/attachment.html>


More information about the llvm-commits mailing list