[llvm-commits] Tablgen bugfix

[Michael Liao]

LGTM. - Michael

On Thu, 2013-01-24 at 02:16 -0800, Malul, Elior wrote:
> Hi Michel, thx for the comment.
> I changed all the related variables to be of size_t.
> Although that requires a cast from uint64_t to size_t, I don't see a situation where POS have a value bigger 2^32,
> (I mean, who would like to write a file header in offset 4GB??).
> Thx, Elior
> 
> -----Original Message-----
> From: Liao, Michael 
> Sent: Wednesday, January 23, 2013 20:36
> To: Malul, Elior
> Cc: dag at cray.com; llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] Tablgen bugfix
> 
> One minor comment, don't mix 'size_t' with 'unsigned'. Potential warning
> on 64-bit system.
> 
> Yours
> - Michael
> 
> On Wed, 2013-01-23 at 11:26 +0000, Malul, Elior wrote:
> > Hi Dag, thx for the comment.
> > There were two lines that exceeded the 80-chars limit. (Fixed it).
> > Thx, Elior
> > 
> > -----Original Message-----
> > From: dag at cray.com [mailto:dag at cray.com] 
> > Sent: Tuesday, January 22, 2013 18:20
> > To: Malul, Elior
> > Cc: llvm-commits at cs.uiuc.edu
> > Subject: Re: [llvm-commits] Tablgen bugfix
> > 
> > "Malul, Elior" <elior.malul at intel.com> writes:
> > 
> > > Yes it is, in fact the logics in this line has not been changed. (I just replaced the hard-coded '80' with MAX_LINE_LEN).
> > 
> > Sorry, I was asking about the coding standards, not the output line
> > length.  Is the loop statement within the 80 char limit?
> > 
> >                            -David
> > 
> > > Thx, Elior
> > >
> > > -----Original Message-----
> > > From: dag at cray.com [mailto:dag at cray.com] 
> > > Sent: Monday, January 21, 2013 22:31
> > > To: Malul, Elior
> > > Cc: llvm-commits at cs.uiuc.edu
> > > Subject: Re: [llvm-commits] Tablgen bugfix
> > >
> > > "Malul, Elior" <elior.malul at intel.com> writes:
> > >
> > >> Attached it a fix to the function, which when it encounters a 
> > >> description string longer than 80 character, it splits to several 
> > >> lines.  I will appreciate if those who care about tblgen will review 
> > >> it.
> > >
> > >> +  for (unsigned i = OS.tell() - Pos, e = MAX_LINE_LEN - 
> > >> + Suffix.size(); i < e; ++i)
> > >
> > > Is this still within the 80 column limit?
> > >
> > > Otherwise, LGTM.
> > >
> > >                           -David
> > > ---------------------------------------------------------------------
> > > Intel Israel (74) Limited
> > >
> > > This e-mail and any attachments may contain confidential material for
> > > the sole use of the intended recipient(s). Any review or distribution
> > > by others is strictly prohibited. If you are not the intended
> > > recipient, please contact the sender and delete all copies.
> > ---------------------------------------------------------------------
> > Intel Israel (74) Limited
> > 
> > This e-mail and any attachments may contain confidential material for
> > the sole use of the intended recipient(s). Any review or distribution
> > by others is strictly prohibited. If you are not the intended
> > recipient, please contact the sender and delete all copies.
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
>