[llvm-commits] [PATCH] [lld] Use CLI/Target entrypoint instead of default "_start" in WriterOptionsELF

[Ahmed Bougacha]

On Thu, Jan 17, 2013 at 4:24 PM, Shankar Easwaran
<shankare at codeaurora.org> wrote:
> I am working on a patch where the options are going to be defined in the
> target. There would be a TargetInfo class which would define all the needed
> options which WriterELFOptions / ReaderELFOptions would contain.

Here is an updated version of the entrypoint patch, made much shorter
by your work.

Thanks,
-- Ahmed Bougacha

> Thanks
>
> Shankar Easwaran
>
>
> On 1/17/2013 8:43 AM, Ahmed Bougacha wrote:
>
> Hi Michael, Nick, all,
>
> I was toying with lld when I noticed command-line and target-defined
> entrypoints are never used, with the entrypoint always defaulting to
> _start. With the small attached patch it works as expected.
>
> When writing a testcase, I also noticed lld-core doesn't accept a
> --entry= argument, so I added it too. For now, this is only used by
> WriterOptionsELF.
>
> As to other writers, how about making WriterOptionsELF a WriterOptions
> and adding the entrypoint there for all Writers to use? If no one is
> working on it and it's ok I can take care of it.
>
> Thanks,
>
> -- Ahmed Bougacha
-------------- next part --------------
A non-text attachment was scrubbed...
Name: entrypoint.diff
Type: application/octet-stream
Size: 4302 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130124/68f35eac/attachment.obj>