[llvm-commits] [llvm] r173325 - /llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp

[NAKAMURA Takumi]

David, yeah, it makes sense.

I really wanted to fill the paths, then. :)

...Takumi

2013/1/24 David Blaikie <dblaikie at gmail.com>:
> I believe the correct (stylistically) change here is to change the 'if' to
> 'assert', rather than adding else-unreachable
>
> On Jan 23, 2013 10:11 PM, "NAKAMURA Takumi" <geek4civic at gmail.com> wrote:
>>
>> Author: chapuni
>> Date: Thu Jan 24 00:08:06 2013
>> New Revision: 173325
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=173325&view=rev
>> Log:
>> MipsISelLowering.cpp: Fill unreachable paths to fix warnings.
>> [-Wsometimes-uninitialized]
>>
>> FIXME: Could they, unreachable(s), be removed?
>> FIXME: I could prefer the coding standards...
>>
>> Modified:
>>     llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
>>
>> Modified: llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp?rev=173325&r1=173324&r2=173325&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp (original)
>> +++ llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp Thu Jan 24 00:08:06
>> 2013
>> @@ -2917,6 +2917,12 @@
>>                 (RetTy->getContainedType(1)->isDoubleTy())) {
>>          result = dcMips16Helper[stubNum];
>>        }
>> +      else {
>> +        llvm_unreachable("Uncovered condition");
>> +      }
>> +    }
>> +    else {
>> +      llvm_unreachable("Uncovered condition");
>>      }
>>    }
>>    else {
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits