[llvm-commits] [PATCH] bugpoint: clean up status messages

[Saleem Abdulrasool]

Hi chandlerc,

Override the value of Message *after* the GCC runner has been constructed as
otherwise, the message will be overwritten by the construction of the runner,
resulting in misleading messages.

Help separate which interpreter was actually not selected (safe vs unsafe).


http://llvm-reviews.chandlerc.com/D319

Files:
  tools/bugpoint/ExecutionDriver.cpp
  tools/bugpoint/ToolRunner.cpp

Index: tools/bugpoint/ExecutionDriver.cpp
===================================================================
--- tools/bugpoint/ExecutionDriver.cpp
+++ tools/bugpoint/ExecutionDriver.cpp
@@ -230,7 +230,7 @@
     }
     if (!SafeInterpreter) {
       SafeInterpreterSel = AutoPick;
-      Message = "Sorry, I can't automatically select an interpreter!\n";
+      Message = "Sorry, I can't automatically select a safe interpreter!\n";
     }
     break;
   case RunLLC:
Index: tools/bugpoint/ToolRunner.cpp
===================================================================
--- tools/bugpoint/ToolRunner.cpp
+++ tools/bugpoint/ToolRunner.cpp
@@ -531,12 +531,12 @@
     return 0;
   }
 
-  Message = "Found llc: " + LLCPath + "\n";
   GCC *gcc = GCC::create(Message, GCCBinary, GCCArgs);
   if (!gcc) {
     errs() << Message << "\n";
     exit(1);
   }
+  Message = "Found llc: " + LLCPath + "\n";
   return new LLC(LLCPath, gcc, Args, UseIntegratedAssembler);
 }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D319.1.patch
Type: text/x-patch
Size: 966 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130122/7508e1dd/attachment.bin>