[llvm-commits] [PATCH] Adding x32 ABI triple and separate StackSlotSize in MCAsmInfo

Eli Bendersky eliben at google.com
Tue Jan 22 14:35:16 PST 2013


>>
>> Evan, I'm not sure what you're referring to here. Could you please clarify?
>
> CalleeSaveStackSlotSize now has special meaning when it is zero, perhaps something like CalleeSaveStackSlotSizeOverride is more appropriate? I personally really don't like this, I think it optimizing for out-of-tree targets is not the right approach. It's making the code harder to understand.
>

I'm fine with reverting to the originally proposed approach of simply
setting this value in the target MCAsmInfo constructors and losing the
"if 0 then use default" behavior.

Eli




More information about the llvm-commits mailing list