[llvm-commits] [PATCH] Adding x32 ABI triple and separate StackSlotSize in MCAsmInfo

[Eli Bendersky]

On Tue, Jan 22, 2013 at 9:15 AM, Nadav Rotem <nrotem at apple.com> wrote:
> Can we initialize StackSlotSize to zero and change getStackSlotSize to return PointerSize unless this value is overridden ?  This will allow us to keep most targets unmodified.
>
> Otherwise LGTM.
>
>

Yes, I've actually considered this or a similar approach for more
"defaultness". After some thinking it seemed to me that being explicit
is more important here. While the changes to each target are trivial,
they allow to see all the important values set in a single place (the
MCAsmInfo subclass constructor), without requiring someone reading the
code to hunt up in the base class.
That said, if you think it's important to keep the targets untouched,
I don't feel strongly about this and will revise the patch.

Eli