[llvm-commits] [llvm] r173010 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[Craig Topper]

This change was very specific to the loop that the code is using. While its
in shuffle code its not looking at the shuffle indices. It's just checking
to see if the 128-bit lanes are linked using a variable that's specific to
this loop. The value is either -1(not linked) or a positive value(linked).

On Mon, Jan 21, 2013 at 12:22 PM, <dag at cray.com> wrote:

> Craig Topper <craig.topper at gmail.com> writes:
>
> > Author: ctopper
> > Date: Mon Jan 21 01:25:16 2013
> > New Revision: 173010
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=173010&view=rev
> > Log:
> > Use <0 checks in place of ==-1 because it results in simpler code.
>
> Is that perhaps obscuring the intent?  -1 is a special UNDEF value.  I
> preferred the old code where we had an isUNDEF helper.
>
>                                     -David
>



-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130121/594bb553/attachment.html>