[llvm-commits] [PATCH] [lld] Add TargetInfo abstraction.

Michael Spencer bigcheesegs at gmail.com
Fri Jan 18 16:17:58 PST 2013



================
Comment at: include/lld/ReaderWriter/ELFTargetInfo.h:25
@@ +24,3 @@
+
+  static std::unique_ptr<ELFTargetInfo> create(const LinkerOptions &lo);
+};
----------------
kledzik at apple.com wrote:
> Why is there this factory method, when the constructor is also public?  Do you intend for there to be hidden subclasses of ELFTargetInfo?
It's public because it was easier to test like that. It should be protected.


http://llvm-reviews.chandlerc.com/D311



More information about the llvm-commits mailing list