[llvm-commits] [llvm] r172851 - in /llvm/trunk: include/llvm/ADT/StringExtras.h lib/Support/APFloat.cpp

Jordan Rose jordan_rose at apple.com
Fri Jan 18 14:09:04 PST 2013


On Jan 18, 2013, at 14:06 , Sean Silva <silvas at purdue.edu> wrote:

> On Fri, Jan 18, 2013 at 4:45 PM, Jordan Rose <jordan_rose at apple.com> wrote:
>> This is duplicated in a couple places in the codebase
> 
> Did you mean to remove that duplication in this patch? I only see one
> "duplication" removed.

There's a Clang-side copy as well, which I haven't committed because my tree is dirty. I admit I was lazy about finding all the instances of this…I just searched, case-insensitively, for "hexdigitvalue". If you'd like me to do a better job, I will. :-)

(The UCN patch I'm discussing with Richard adds two more Clang-side uses as well.)

Jordan



More information about the llvm-commits mailing list