[llvm-commits] [llvm] r170456 - in /llvm/trunk: include/llvm/CodeGen/MachineBasicBlock.h lib/CodeGen/MachineBasicBlock.cpp

[Krzysztof Parzyszek]

On 12/18/2012 2:59 PM, Jakob Stoklund Olesen wrote:
> Author: stoklund
> Date: Tue Dec 18 14:59:41 2012
> New Revision: 170456
>
> URL: http://llvm.org/viewvc/llvm-project?rev=170456&view=rev
> Log:
> Tighten up the splice() API for bundled instructions.
>
> Remove the instr_iterator versions of the splice() functions. It doesn't
> seem useful to be able to splice sequences of instructions that don't
> consist of full bundles.

Ok, I'm a bit late to see this, but...

How about this:

BUNDLE
* Instr1
* Instr2
* Instr3

and now I want to take one instruction out and place it outside of the 
bundle?  Now I will need to update the neighbors, which needs to take 
care of the corner cases (bundle boundaries).  I don't see any 
convenient way of doing this in the current code (mid-January).


What kind of an argument is "it doesn't seem useful"?  What if it seems 
useful to somebody else?  I understand the motivation of speeding up 
some commonly used functions, and that the underlying details may 
change, but core API changes like this should be minimized.

-Krzysztof


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation