[llvm-commits] [llvm] r171738 - /llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp

[Bill Wendling]

Hi Chandler,

On Jan 7, 2013, at 7:04 AM, Chandler Carruth <chandlerc at gmail.com> wrote:

> Author: chandlerc
> Date: Mon Jan  7 09:04:40 2013
> New Revision: 171738
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=171738&view=rev
> Log:
> Remove LSR's use of the random AddrMode struct. These variables were
> already in a class, just inline the four of them. I suspect that this
> class could be simplified some to not always keep distinct variables for
> these things, but it wasn't clear to me how given the usage so I opted
> for a trivial and mechanical translation.
> 
> This removes one of the two remaining users of a header in include/llvm
> which does nothing more than define a 4 member struct.
> 
> Modified:
>    llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp
> 
> Modified: llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp?rev=171738&r1=171737&r2=171738&view=diff
> ==============================================================================
> @@ -2893,7 +2903,6 @@
>                                        LSRUse &LU, size_t LUIdx) {
>   Formula F;
>   F.BaseRegs.push_back(S);
> -  F.AM.HasBaseReg = true;

Did you intend to remove this assignment entirely?

>   bool Inserted = InsertFormula(LU, LUIdx, F);
>   assert(Inserted && "Supplemental formula already exists!"); (void)Inserted;
> }

-bw