[llvm-commits] [lld] support for adding absolute symbols in WriterELF

Sean Silva silvas at purdue.edu
Thu Jan 10 22:38:16 PST 2013


On Wed, Jan 9, 2013 at 2:42 PM, Shankar Easwaran
<shankare at codeaurora.org> wrote:
>> -RUN: lld -flavor ld -target x86_64-linux
>> +# Will fail with unersolved symbol
>> +RUN: lld -flavor ld -target x86_64-linux || exit 0
>
> This is a obscure test, I discussed with Michael on this, I think its just
> testing the arguments.

Hi Michael, Shankar:

Could you explain the purpose of this test? The `|| exit 0` means that
it can't possibly fail (even if lld segfaults or aborts, or the lld
executable isn't present), so what is it supposed to test? This
particular test appears to be causing some cargo culting in Shankar's
latest patch, which introduces the analogous bizarre test for hexagon.

-- Sean Silva



More information about the llvm-commits mailing list