[llvm-commits] [compiler-rt] r172068 - /compiler-rt/trunk/lib/sanitizer_common/tests/standalone_malloc_test.cc

[Kostya Serebryany]

On Thu, Jan 10, 2013 at 9:56 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Thu, Jan 10, 2013 at 5:33 AM, Kostya Serebryany <kcc at google.com> wrote:
> > Author: kcc
> > Date: Thu Jan 10 07:33:15 2013
> > New Revision: 172068
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=172068&view=rev
> > Log:
> > [sanitizer] fix the non-cmake build (2-nd attempt)
> >
> > Modified:
> >
> compiler-rt/trunk/lib/sanitizer_common/tests/standalone_malloc_test.cc
> >
> > Modified:
> compiler-rt/trunk/lib/sanitizer_common/tests/standalone_malloc_test.cc
> > URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/standalone_malloc_test.cc?rev=172068&r1=172067&r2=172068&view=diff
> >
> ==============================================================================
> > ---
> compiler-rt/trunk/lib/sanitizer_common/tests/standalone_malloc_test.cc
> (original)
> > +++
> compiler-rt/trunk/lib/sanitizer_common/tests/standalone_malloc_test.cc Thu
> Jan 10 07:33:15 2013
> > @@ -56,4 +56,5 @@
> >    for (size_t i = 0; i < kNumThreds; i++)
> >      pthread_join(t[i], 0);
> >    malloc_stats();
> > +  return 0;
>
> What differences between the cmake and configure+make (I assume that's
> the "non-cmake build" you're referring to) exist that lead you to need
> to make this change? That seems like an inconsistency that
> could/should be fixed.
>

cmake has a list of files to compile and then link into a test.
configure+make uses a wild card. This file matches the wild card but I did
not intend to link it together with other tests.

--kcc




>
> >  }
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130110/60f25703/attachment.html>