[llvm-commits] [PATCH] [msan] Change va_start/va_copy shadow memcpy alignment to 8

[Evgeniy Stepanov]

  Yes, that's probably it.
  Thanks!
  LGTM.


================
Comment at: test/Instrumentation/MemorySanitizer/msan_basic.ll:548
@@ +547,2 @@
+; CHECK: @VACopy
+; CHECK: call void @llvm.memset.p0i8.i64({{.*}}, i8 0, i64 24, i32 8, i1 false)
----------------
Please add a check for "ret void" at the end.

================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:1788
@@ -1787,3 +1787,3 @@
     IRB.CreateMemSet(ShadowPtr, Constant::getNullValue(IRB.getInt8Ty()),
-                     /* size */ 24, /* alignment */ 16, false);
+                     /* size */ 24, /* alignment */ 8, false);
   }
----------------
Please remove the extra spaces between comments and numbers while you are at it.


http://llvm-reviews.chandlerc.com/D276

BRANCH
  msan-va-align

ARCANIST PROJECT
  llvm