[llvm-commits] [PATCH] Enhance TableGen with ranges and fixits

[Jordan Rose]

On Jan 7, 2013, at 19:17 , Sean Silva <silvas at purdue.edu> wrote:

> On Mon, Jan 7, 2013 at 10:04 PM, Jordan Rose <jordan_rose at apple.com> wrote:
>> Heh, I was expecting someone to say that. No one is using fixits yet; I'm planning to add them to Clang's tablegen (just sent to cfe-commits). But I also didn't have a test there because I wasn't sure how we do tablegen-based tests. I guess it should be easy enough to add a dummy test to Misc that calls clang-tblgen, though. I'll work that up...hopefully tomorrow.
> 
> there's llvm/test/TableGen/ which has a surprisingly large collection
> of tests (although some of them are a bit questionable).

And of course, testing actually caught some issues with SMFixIt, so thanks, Sean. Revised patches attached. I've also included the test file I'm using for fixit features, though it has to live up on the Clang side since clang-tblgen is the only user of SMFixIt right now.

I'll update the other thread on cfe-commits with the full test suite.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-TableGen-record-anonymous-instantiations-of-classes.patch
Type: application/octet-stream
Size: 4835 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130109/67208751/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-TableGen-Keep-track-of-superclass-reference-ranges.patch
Type: application/octet-stream
Size: 15905 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130109/67208751/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-basic-fix-its-to-SMDiagnostic.patch
Type: application/octet-stream
Size: 16438 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130109/67208751/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tg-fixits.td
Type: application/octet-stream
Size: 1912 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130109/67208751/attachment-0003.obj>