[llvm-commits] [patch] Add TLS hook to MCTargetExpr (AArch64 generic change)

[Eric Christopher]

Hi Tim,

In practice this means that existing targets put their TLS operand variants
> into the global namespace (VK_ARM_TLSGD, VK_Mips_DTPREL_HI, ...). However,
> the
> AArch64 target has more of these modifiers than all other targets combined
> and
> I felt it was inappropriate to pollute the global space for them.
>
> This patch adds a virtual callback to MCTargetExpr so that analysis doesn't
> stop at this barrier and the work can be delegated to the target.
>
> I believe this can be improved further; the implementatoin of
> MCTargetExpr::fixELFSymbolsInTLSFixups involves more duplication than I'd
> like. However, I would prefer to delay this further refactoring until
> AArch64
> is committed since it would provide an example use to reason from more
> easily.
>
> Can I commit it?
>

No objection per se, but it'd be nice to see the cleanups in at least one
target as the
motivation for the change?

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130109/c4532b6a/attachment.html>