[llvm-commits] Typo fix in lib/CodeGen/MachineInstr.cpp. Please review.

[Sergei Larin]

David,

   Unfortunately no. The bug is exposed in an experimental code, and I am
not sure how to reproduce it on the tip.
The problem is rather obvious though, and clearly a cut/paste kind of thing.

Sergei

---
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation


> -----Original Message-----
> From: David Blaikie [mailto:dblaikie at gmail.com]
> Sent: Tuesday, January 08, 2013 2:41 PM
> To: Sergei Larin
> Cc: Jakob Stoklund Olesen; llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] Typo fix in lib/CodeGen/MachineInstr.cpp.
> Please review.
> 
> On Tue, Jan 8, 2013 at 12:07 PM, Sergei Larin <slarin at codeaurora.org>
> wrote:
> >
> > Jakob,
> >
> >   There is a trivial typo in MachineInstr::unbundleFromSucc() method.
> 
> Do you have a test case to go with this?
> 
> > Please OK the fix:
> >
> > Index: lib/CodeGen/MachineInstr.cpp
> > ===================================================================
> > --- lib/CodeGen/MachineInstr.cpp    (revision 171865)
> > +++ lib/CodeGen/MachineInstr.cpp    (working copy)
> > @@ -897,7 +897,7 @@
> >    assert(isBundledWithSucc() && "MI isn't bundled with its
> successor");
> >    clearFlag(BundledSucc);
> >    MachineBasicBlock::instr_iterator Succ = this;
> > -  --Succ;
> > +  ++Succ;
> >    assert(Succ->isBundledWithPred() && "Inconsistent bundle flags");
> >    Succ->clearFlag(BundledPred);
> >  }
> >
> > Thanks.
> >
> > Sergei
> >
> > ---
> > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> > hosted by The Linux Foundation
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >